Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find all references: show error if code contains syntax errors #153

Open
larshp opened this issue Mar 6, 2024 · 1 comment · May be fixed by #163
Open

find all references: show error if code contains syntax errors #153

larshp opened this issue Mar 6, 2024 · 1 comment · May be fixed by #163

Comments

@larshp
Copy link
Member

larshp commented Mar 6, 2024

as the list will be empty, which is misleading

@marcellourbani
Copy link
Contributor

Looking into this now.
I see 3 ways of doing it:

  1. checking diagnostics in onReferences when references is empty
  2. maintaining a list of files with broken syntax on the server and check that
  3. changing core to throw an exception in References.references when syntax is broken (or perhaps even lower, say in lookup or even spaghetti )

Probably going for (1)

marcellourbani added a commit to marcellourbani/vscode-abaplint that referenced this issue Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants