Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize diff #1

Open
abentkamp opened this issue Jun 25, 2024 · 0 comments
Open

Minimize diff #1

abentkamp opened this issue Jun 25, 2024 · 0 comments

Comments

@abentkamp
Copy link
Owner

abentkamp commented Jun 25, 2024

See diff in this PR: hhu-adam/monaco-lean4#1

Overview of diff:

  • Set language ID to lean first and then to lean4?
  • [webview/index.ts] Loading scripts was easier using imports, but might be possible using the loader as well

Addressed:

  • [leanclient.ts] collectAllOpenLeanDocumentUris does not work as expected
  • [projectInfo.ts] findLeanProjectRootInfo requires filesystem
  • [clientProvider.ts] Checks require file system (e.g. checkIsLeanVersionUpToDate)
  • [vscode.css] Stylesheet variables are provided to VSCode webviews automatically. We need to inject it into the iframe by hand.
  • [webview/index.ts] Communication works differently in IFrame
  • [leanclient.ts] Use Monaco Language Client instead of VSCode Language Client
  • [infoview.ts] WebviewPanel in gets replaced by HTMLIFrameElement
    • InfoProvider gets setInfoviewElement function to supply location of infoview
  • [batch.ts/fsHelper.ts] spawn/promises cannot be imported: ambiguous indirect export: using memfs now
  • Vite fails to load abbreviations.json properly (Fixed: 1ce695c)
  • [infoview.ts] Editor.selection for some reason uses _character instead of character. (Fixed: hhu-adam/monaco-lean4@40fa306)
  • [taskgutter.ts] Adjust image paths (Fixed: hhu-adam/monaco-lean4@2a01c47)
  • [logger.ts] Console object seems to work differently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant