Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Other signing algorithms? #60

Open
jon-torodash opened this issue Mar 15, 2023 · 3 comments
Open

Other signing algorithms? #60

jon-torodash opened this issue Mar 15, 2023 · 3 comments

Comments

@jon-torodash
Copy link

The call to sign

            signed_data = sign_message(
                canonicalize(self.payload), self.digest_alg, message.receiver.sign_key
            )

does not pass down sign_alg, so any non-RSA key won't work. Can this be updated?
@abhishek-ram
Copy link
Owner

I guess we would have to store this as a part of the Partner configuration. I do not have the time to pick this right now, would you be able to open a PR

chadgates added a commit to chadgates/pyas2-lib that referenced this issue Mar 20, 2024
@chadgates
abhishek-ram#60 and also making abhishek-ram#62 available on the partner
cbf0659
@chadgates chadgates mentioned this issue Mar 26, 2024
Closed
@chadgates chadgates mentioned this issue Apr 17, 2024
Merged
chadgates added a commit to chadgates/pyas2-lib that referenced this issue Apr 17, 2024
@chadgates
https://github.com/abhishek-ram/pyas2-lib/issues/60
adbd933 
Extending Partner with Signature Algo and pass the setting to signing function.
@chadgates
Copy link
Contributor

@jon-torodash : which other algos are you looking at beside the following that are there?
rsassa_pkcs1v15
rsassa_pss

abhishek-ram pushed a commit that referenced this issue May 1, 2024
@chadgates
Extending Partner with Signature Algo and pass the setting to signing…
499fd03 
… function.

* Fix github action build fail due to:
https://stackoverflow.com/questions/71673404/importerror-cannot-import-name-unicodefun-from-click

* Added partner setting to force canonicalize binary.

* Formatted with black

* #60
Extending Partner with Signature Algo and pass the setting to signing function.
@gertcuykens
Copy link

I assume Ed25519 / EdDSA is the mainstream now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gertcuykens @jon-torodash @abhishek-ram @chadgates