Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed trackable goes to offline when subscriber is stopped #802

Open
davyskiba opened this issue Nov 10, 2022 · 2 comments
Open

Failed trackable goes to offline when subscriber is stopped #802

davyskiba opened this issue Nov 10, 2022 · 2 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@davyskiba
Copy link
Contributor

Stopping the subscriber uses StopConnectionWorker which calls notifyAssetIsOffline function which changes trackable state to Offline.
According to this comment, Failed state is supposed to be final and this transition should not occur.
@davyskiba davyskiba added the bug Something isn't working. It's clear that this does need to be fixed. label Nov 10, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Nov 10, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2922

@QuintinWillison
Copy link
Contributor

I agree that there's something not right with the notifyAssetIsOffline() method of DefaultCoreSubscriber because it seems to break the constraints of property/state update+emit flows established elsewhere. I've added a TODO comment in #855.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuintinWillison @davyskiba