Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings visible in Android Studio should fail the build in CI #858

Open
QuintinWillison opened this issue Dec 20, 2022 · 1 comment
Open

Warnings visible in Android Studio should fail the build in CI #858

QuintinWillison opened this issue Dec 20, 2022 · 1 comment
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@QuintinWillison
Copy link
Contributor

We should be treating warnings as errors.

This "never used" problem was introduced by me when refactoring but didn't fail my local Gradle build, or the build in CI.

Screenshot 2022-12-20 at 13 28 59
@QuintinWillison QuintinWillison added the code-quality Affects the developer experience when working in our codebase. label Dec 20, 2022
@QuintinWillison QuintinWillison mentioned this issue Dec 20, 2022
Merged
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 20, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Affects the developer experience when working in our codebase.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QuintinWillison