Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flakey test: com.ably.tracking.tests.PublisherAndSubscriberTests > createAndStartPublisherAndSubscriberAndWaitUntilDataEnds #954

Open
AndyTWF opened this issue Jan 26, 2023 · 1 comment
Open

Flakey test: com.ably.tracking.tests.PublisherAndSubscriberTests > createAndStartPublisherAndSubscriberAndWaitUntilDataEnds #954

AndyTWF opened this issue Jan 26, 2023 · 1 comment
Assignees
@AndyTWF
Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.

Comments

@AndyTWF
Copy link
Contributor

AndyTWF commented Jan 26, 2023 •
edited
Loading 

com.ably.tracking.tests.PublisherAndSubscriberTests > createAndStartPublisherAndSubscriberAndWaitUntilDataEnds[test(AVD) - 5.0.2] FAILED 
	java.lang.AssertionError: Received Subscriber location should be equal to published Publisher location (index 1) expected:<com.ably.tracking.EnhancedLocationUpdate@5b8b7fec> but was:<com.ably.tracking.EnhancedLocationUpdate@dbdfc939>

First noticed in https://github.com/ably/ably-asset-tracking-android/actions/runs/4017396909/jobs/6901700322

This is most likely caused by EnhancedLocationChangedWorker: it emits every enhanced location updated on the publishers locations flow, but what reaches the subscriber via Ably is controlled by other factors, namely the subscriber resolution. The test is performed by comparing the publisher locations flow (absolutely everything) and the subscribers flow (only what gets sent over Ably). These two cannot be reliably compared.

This could be fixed by addressing #913
@AndyTWF AndyTWF added the failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug. label Jan 26, 2023
@AndyTWF AndyTWF self-assigned this Jan 26, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Jan 26, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndyTWF AndyTWF

Labels
failing-test Where an automated test is failing either locally or in CI. Perhaps flakey, wrong or bug.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndyTWF