From 62bfc0d2ade0f34c5d01aed6d8fd5d104b17ad64 Mon Sep 17 00:00:00 2001 From: Umair Date: Wed, 3 Apr 2024 22:08:21 +0100 Subject: [PATCH 1/2] update changelog --- CHANGELOG.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index cc4444d57..be1836c27 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,13 @@ # Change Log +## [1.2.28](https://github.com/ably/ably-cocoa/tree/1.2.28) + +[Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.27...1.2.28) + +**Fixed issues:** + +- Push Notification corner cases as initially reported in ably-java [\#993](https://github.com/ably/ably-java/issues/993) + ## [1.2.27](https://github.com/ably/ably-cocoa/tree/1.2.27) [Full Changelog](https://github.com/ably/ably-cocoa/compare/1.2.26...1.2.27) From db027a58056814062d05485cf080cd6c094e9313 Mon Sep 17 00:00:00 2001 From: Umair Date: Wed, 3 Apr 2024 22:11:29 +0100 Subject: [PATCH 2/2] bump version to 1.2.28 --- README.md | 4 ++-- Scripts/jazzy.sh | 2 +- Source/ARTClientInformation.m | 2 +- Test/Tests/ARTDefaultTests.swift | 2 +- Test/Tests/ClientInformationTests.swift | 6 +++--- Test/Tests/RealtimeClientConnectionTests.swift | 2 +- Test/Tests/RestClientTests.swift | 2 +- Version.xcconfig | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-) diff --git a/README.md b/README.md index 59120e815..0d2544965 100644 --- a/README.md +++ b/README.md @@ -61,7 +61,7 @@ You can install Ably for iOS and macOS through Package Manager, CocoaPods, Carth - [This apple guide](https://developer.apple.com/documentation/swift_packages/adding_package_dependencies_to_your_app) explains the steps in more detail. - To install the `ably-cocoa` package in another **Swift Package**, then add the following to your `Package.Swift`: ```swift - .package(url: "https://github.com/ably/ably-cocoa", from: "1.2.27"), + .package(url: "https://github.com/ably/ably-cocoa", from: "1.2.28"), ``` ### Installing through [CocoaPods](https://cocoapods.org/) @@ -101,7 +101,7 @@ If you see, for example, a `dyld: Library not loaded: @rpath/AblyDeltaCodec.fram ### Manual installation -1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.27), or clone it to get the latest, unstable and possibly underdocumented version: `git clone git@github.com:ably/ably-cocoa.git` +1. Get the code from GitHub [from the release page](https://github.com/ably/ably-cocoa/releases/tag/1.2.28), or clone it to get the latest, unstable and possibly underdocumented version: `git clone git@github.com:ably/ably-cocoa.git` 2. Drag the directory `ably-cocoa/ably-cocoa` into your project as a group. 3. Ably depends on our [MessagePack Fork](https://github.com/ably-forks/msgpack-objective-C) 0.2.0; get it [from the releases page](https://github.com/ably-forks/msgpack-objective-C/releases/tag/0.2.0-ably-1) and link it into your project. diff --git a/Scripts/jazzy.sh b/Scripts/jazzy.sh index 756b7ca89..b37150424 100755 --- a/Scripts/jazzy.sh +++ b/Scripts/jazzy.sh @@ -7,7 +7,7 @@ jazzy \ --objc \ --clean \ --author Ably \ - --module-version 1.2.27 \ + --module-version 1.2.28 \ --umbrella-header Source/include/Ably/Ably.h \ --framework-root Source \ --module Ably \ diff --git a/Source/ARTClientInformation.m b/Source/ARTClientInformation.m index 48ab1b6e9..48cf16d5d 100644 --- a/Source/ARTClientInformation.m +++ b/Source/ARTClientInformation.m @@ -6,7 +6,7 @@ #import NSString *const ARTClientInformationAgentNotVersioned = @"ARTClientInformationAgentNotVersioned"; -NSString *const ARTClientInformation_libraryVersion = @"1.2.27"; +NSString *const ARTClientInformation_libraryVersion = @"1.2.28"; static NSString *const _libraryName = @"ably-cocoa"; // NSOperatingSystemVersion has NSInteger as version components for some reason, so mitigate it here. diff --git a/Test/Tests/ARTDefaultTests.swift b/Test/Tests/ARTDefaultTests.swift index d3f447959..0e6ab8a60 100644 --- a/Test/Tests/ARTDefaultTests.swift +++ b/Test/Tests/ARTDefaultTests.swift @@ -6,6 +6,6 @@ class ARTDefaultTests: XCTestCase { func testVersions() { XCTAssertEqual(ARTDefault.apiVersion(), "2") - XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.27") + XCTAssertEqual(ARTDefault.libraryVersion(), "1.2.28") } } diff --git a/Test/Tests/ClientInformationTests.swift b/Test/Tests/ClientInformationTests.swift index ee83479ae..2b53e289a 100644 --- a/Test/Tests/ClientInformationTests.swift +++ b/Test/Tests/ClientInformationTests.swift @@ -9,7 +9,7 @@ final class ClientInformationTests: XCTestCase { XCTAssertEqual(agents.keys.count, 2) - XCTAssertEqual(agents["ably-cocoa"], "1.2.27") + XCTAssertEqual(agents["ably-cocoa"], "1.2.28") #if os(iOS) XCTAssertTrue(agents.keys.contains("iOS")) @@ -27,7 +27,7 @@ final class ClientInformationTests: XCTestCase { // CR3, CR3b func testAgentIdentifierWithAdditionalAgents_withNilAdditionalAgents() { let expectedIdentifier = [ - "ably-cocoa/1.2.27", + "ably-cocoa/1.2.28", ARTDefault.platformAgent() ].sorted().joined(separator: " ") @@ -42,7 +42,7 @@ final class ClientInformationTests: XCTestCase { ] let expectedIdentifier = [ - "ably-cocoa/1.2.27", + "ably-cocoa/1.2.28", "demolib/0.0.1", "morelib", ARTDefault.platformAgent() diff --git a/Test/Tests/RealtimeClientConnectionTests.swift b/Test/Tests/RealtimeClientConnectionTests.swift index fe0013ecb..adfd72bca 100644 --- a/Test/Tests/RealtimeClientConnectionTests.swift +++ b/Test/Tests/RealtimeClientConnectionTests.swift @@ -381,7 +381,7 @@ class RealtimeClientConnectionTests: XCTestCase { done() case .connected: if let transport = client.internal.transport as? TestProxyTransport, let query = transport.lastUrl?.query { - expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.27")) + expect(query).to(haveParam("agent", hasPrefix: "ably-cocoa/1.2.28")) } else { XCTFail("MockTransport isn't working") } diff --git a/Test/Tests/RestClientTests.swift b/Test/Tests/RestClientTests.swift index c11dcbb72..5e30cf116 100644 --- a/Test/Tests/RestClientTests.swift +++ b/Test/Tests/RestClientTests.swift @@ -1736,7 +1736,7 @@ class RestClientTests: XCTestCase { let headerAgent = testHTTPExecutor.requests.first!.allHTTPHeaderFields?["Ably-Agent"] let ablyAgent = ARTClientInformation.agentIdentifier(withAdditionalAgents: options.agents) XCTAssertEqual(headerAgent, ablyAgent) - XCTAssertTrue(headerAgent!.hasPrefix("ably-cocoa/1.2.27")) + XCTAssertTrue(headerAgent!.hasPrefix("ably-cocoa/1.2.28")) done() } } diff --git a/Version.xcconfig b/Version.xcconfig index 881dda667..33c1b0542 100644 --- a/Version.xcconfig +++ b/Version.xcconfig @@ -1 +1 @@ -CURRENT_PROJECT_VERSION = 1.2.27 +CURRENT_PROJECT_VERSION = 1.2.28