Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Accept header setup for each request individually #1444

Open
maratal opened this issue Jul 8, 2022 · 0 comments
Open

Remove Accept header setup for each request individually #1444

maratal opened this issue Jul 8, 2022 · 0 comments
Labels
enhancement New feature or improved functionality.

Comments

@maratal
Copy link
Collaborator

maratal commented Jul 8, 2022 •
edited by sync-by-unito bot
Loading

I've just noticed we should probably also set the Accept header on the request, [again similarly to -[ARTRest time:]]

I think it's a legacy code. Accept header is set later here for all requests:

ably-cocoa/Source/ARTRest.m

Line 313 in 0fe3c59

[mutableRequest setAcceptHeader:self.defaultEncoder encoders:self.encoders];

Originally posted by maratal in #1420 (comment)

┆Issue is synchronized with this Jira Task by Unito
@maratal maratal mentioned this issue Jul 8, 2022
Merged
maratal pushed a commit that referenced this issue Jul 19, 2023
Merge pull request #1444 from ably/message_interactions
887fac3 
Message Interactions
@umair-ably umair-ably added the enhancement New feature or improved functionality. label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improved functionality.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maratal @umair-ably