From 32c7cb2cc537d00cc3318d71ef17cffe327adfe7 Mon Sep 17 00:00:00 2001 From: sacOO7 Date: Tue, 27 Jun 2023 22:59:55 +0530 Subject: [PATCH 1/3] Updated README with MAUI trimming config. --- README.md | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 5fb34b981..ed039a22d 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ This is a .NET client library for Ably. The library currently targets the [Ably ## Supported platforms * [.NET Standard 2.0+](https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0) -* .NET 6.x, 7.x (MAUI supported) +* .NET 6.x, 7.x, MAUI, check [MAUI config](#maui-configuration). * .NET Framework 4.6.2+ * .NET (Core) 2.0+ * Mono 5.4+ @@ -446,6 +446,17 @@ options.TransportFactory = new MsWebSocketTransport.TransportFactory(websocketOp var realtime = new AblyRealtime(options); ``` +### MAUI configuration +- Make sure to disable assembly trimming for `IO.Ably`. +- Add following to the `.csproj` file. +``` + + + +``` +- For more information related to assembly trimming, check [MAUI trimming doc](https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/trimming-options). + + ### Examples * More Examples can be found under ```examples``` directory. From fa108acb3d672b3a3be9f43b6d33b8a37eae87ac Mon Sep 17 00:00:00 2001 From: sachin shinde Date: Wed, 5 Jul 2023 15:26:25 +0530 Subject: [PATCH 2/3] Update README.md for MAUI config Co-authored-by: Owen Pearson <48608556+owenpearson@users.noreply.github.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ed039a22d..a1319b727 100644 --- a/README.md +++ b/README.md @@ -449,7 +449,7 @@ var realtime = new AblyRealtime(options); ### MAUI configuration - Make sure to disable assembly trimming for `IO.Ably`. - Add following to the `.csproj` file. -``` +```xml From c7cb15b4d80f57967b9439ef0a2536f0dbec40a1 Mon Sep 17 00:00:00 2001 From: sacOO7 Date: Wed, 5 Jul 2023 15:38:08 +0530 Subject: [PATCH 3/3] Updated maui config. readme according to suggestion --- README.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index a1319b727..7050b8a4c 100644 --- a/README.md +++ b/README.md @@ -447,8 +447,9 @@ var realtime = new AblyRealtime(options); ``` ### MAUI configuration -- Make sure to disable assembly trimming for `IO.Ably`. -- Add following to the `.csproj` file. +- Since `ably-dotnet` makes use of the reflection API, MAUI assembly trimming may cause issues. +- When using MAUI, we recommend adding the following to your `.csproj` file to disable assembly trimming. + ```xml