Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No async version of IRestChannel.Status #1263

Closed
fdmarc opened this issue Sep 27, 2023 · 2 comments
Closed

No async version of IRestChannel.Status #1263

fdmarc opened this issue Sep 27, 2023 · 2 comments
Assignees

Comments

@fdmarc
Copy link

fdmarc commented Sep 27, 2023

IRestChannel.Status is a blocking function, and there is no async equivalent in the API. This is in contrast to .Publish / .PublishAsync and .History / .HistoryAsync.

Indeed, the implementation is implemented in terms of StatusAsync:

        private async Task<ChannelDetails> StatusAsync()
        {
            AblyRequest request = _ablyRest.CreateGetRequest("/channels/" + Name);
            return await _ablyRest.ExecuteRequest<ChannelDetails>(request);
        }

        /// <inheritdoc/>
        public ChannelDetails Status()
        {
            return AsyncHelper.RunSync(StatusAsync);
        }
fdmarc added a commit to flipdishbytes/ably-dotnet that referenced this issue Sep 27, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Sep 27, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3872

@sacOO7
Copy link
Collaborator

sacOO7 commented Oct 17, 2023

Fixed via #1266

@sacOO7 sacOO7 closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants