Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing RTP2f #1277

Open
sacOO7 opened this issue Mar 25, 2024 · 2 comments
Open

Implement missing RTP2f #1277

sacOO7 opened this issue Mar 25, 2024 · 2 comments

Comments

@sacOO7
Copy link
Collaborator

sacOO7 commented Mar 25, 2024 •
edited by sync-by-unito bot
Loading

┆Issue is synchronized with this Jira Task by Unito
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Apr 26, 2024

Also, fix #1271 (comment)

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jun 2, 2024

Make sure msgSerial starts at 0. This is needed for processing ack/nack https://sdk.ably.com/builds/ably/specification/main/features/#RTN7b.
At

ably-dotnet/src/IO.Ably.Shared/Realtime/Workflows/RealtimeWorkflow.cs

Line 591 in 092240b

message.MsgSerial = State.Connection.IncrementSerial();
. Msgserial is incremented to 1 then it is sent to server ( which kinda seems like a bug )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sacOO7