From bbabe08f8bc09103d531f5b7df85acae137fbac6 Mon Sep 17 00:00:00 2001 From: sacOO7 Date: Mon, 8 Jul 2024 13:44:32 +0530 Subject: [PATCH 1/2] Fixed yeild statement inside disconnect and reconnect lamda for channel detach --- lib/ably/realtime/channel/channel_manager.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ably/realtime/channel/channel_manager.rb b/lib/ably/realtime/channel/channel_manager.rb index 90f00b9e..50ccd316 100644 --- a/lib/ably/realtime/channel/channel_manager.rb +++ b/lib/ably/realtime/channel/channel_manager.rb @@ -243,10 +243,10 @@ def send_detach_protocol_message(previous_state) end end - on_disconnected_and_connected = lambda do + on_disconnected_and_connected = lambda do |&block| connection.unsafe_once(:disconnected) do connection.unsafe_once(:connected) do - yield if pending_state_change_timer + block.call if pending_state_change_timer end if pending_state_change_timer end end From 3bed6feee3a89990d46e8b732ddf9bd030a89dd4 Mon Sep 17 00:00:00 2001 From: sacOO7 Date: Mon, 8 Jul 2024 14:14:39 +0530 Subject: [PATCH 2/2] Removed unncessary check from test to detach channel after attaching state --- spec/acceptance/realtime/channel_spec.rb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/spec/acceptance/realtime/channel_spec.rb b/spec/acceptance/realtime/channel_spec.rb index 4286c6a9..25f4a7c6 100644 --- a/spec/acceptance/realtime/channel_spec.rb +++ b/spec/acceptance/realtime/channel_spec.rb @@ -830,10 +830,8 @@ def disconnect_transport it 'does the detach operation once the connection state is connected (#RTL5h)' do connection.once(:connected) do connection.once(:disconnected) do - channel.on :attaching do - channel.detach - end channel.attach + channel.detach connection.once(:connected) do channel.once(:attached) do channel.once(:detached) do