Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need to improve the update commit message #27

Open
pombredanne opened this issue Jan 17, 2023 · 2 comments
Open

We need to improve the update commit message #27

pombredanne opened this issue Jan 17, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@pombredanne
Copy link
Contributor

See https://github.com/nexB/scancode-licensedb/blob/4c45c3fa5fb2e21147148882f30d9e3a13d17f85/.github/workflows/daily-update.yml#L34

This should be using a DCO and there should be a link to the SCTK commit.
@AyanSinhaMahapatra
Copy link
Contributor

Yes, I was confused what name/email to use for this signoff, what do you think?

@pombredanne
Copy link
Contributor Author

whatever user is the one committing

@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this issue Jan 18, 2023
Closed
@AyanSinhaMahapatra AyanSinhaMahapatra added the good first issue Good for newcomers label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pombredanne @AyanSinhaMahapatra