Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas price is hardcoded in membership token transfer flow #5

Open
adklempner opened this issue May 18, 2020 · 1 comment
Open

Gas price is hardcoded in membership token transfer flow #5

adklempner opened this issue May 18, 2020 · 1 comment

Comments

@adklempner
Copy link
Contributor

In the flow TRF ERC20 Token, node Contract Executor, the gas price is hard coded:

let overrides = {
    // The maximum units of gas for the transaction to use
    gasLimit: 800000,

    // The price (in wei) per unit of gas
    gasPrice: ethers.utils.parseUnits('8.0', 'gwei'),

};

As the average gas price on the network grew, I had to keep rewriting the value so that transactions for membership tokens would succeed relatively quickly. It would be easier if the gas price for this transaction (and perhaps other transactions?) was a global const. However, I'm not sure how this would interact with the other gas-related global constants, min_eth_for_gas_fee and gas_buffer

Ideally, the gas price would be determined by data from something like the Eth Gas Station API

@kedMertens
Copy link

Hi!
I'm participating in DAO Hack Month and would like to resolve that issue as a part of my project, it is ok?
The project is aiming to propose additional features and some improvements of dao-help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants