Redefining an imported type is allowed

[salujajaskeerat]

Bug Report 🐛

When I try to redefine an imported type in the file, it should throw an error as there should be a name conflict.
For example, below code :

namespace org.accordproject.color@1.0.0

import org.test.color@1.0.0.{doc} 

concept doc {
    o String detail
}

concept files{
    o doc[]  documents
}

Here, I am trying to redefine the concept doc imported above. Should this be allowed?

Expected Behavior

It should throw an error stating the name conflict. As mentioned above, local type doc has two definitions, i.e. [email protected] and [email protected]

Current Behavior

The code gets compiled successfully. Inside the concept files, the type doc gets resolved to [email protected], which is from the import statement.

Possible Solution

In concerto/core inside the model file validation, we test if the declaration has unique names or not. We don't check with the imported types there. Just checking there with the imports could fix this issue.

Check the validation code here.

concerto/packages/concerto-core/lib/introspect/modelfile.js

Line 276 in 9e61044

// Check if names of the declarations are unique.

[aryan917]

you can modify it better as short and precise.
concept doc {
o String title
o Date created Date
o String content
}

concept files {
o doc[] documents
}

[yashsaraswat2004]

please assign this issue to me

[salujajaskeerat]

please assign this issue to me

@yashsaraswat2004 It is great so see your motivation towards contributing to this issue and concerto in general . Currently we (Internally) are working on closing this issue already so i would suggest you to pickup some different issue. I suggest you to join Accord discord channel and explore concerto more.

[dselman]

Thanks both. I agree this would be a good issue to fix. Note that we recently added support for import aliasing which is useful for name conflicts.

[dselman]

What is the status of this please?