Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider handling of outer SPARQL solution modifiers #206

Open
lu-pl opened this issue Jan 27, 2025 · 0 comments
Open

Consider handling of outer SPARQL solution modifiers #206

lu-pl opened this issue Jan 27, 2025 · 0 comments
Assignees
@lu-pl

Comments

@lu-pl
Copy link
Contributor

lu-pl commented Jan 27, 2025

This issue is a continuation/specialization of #126 .
@lu-pl lu-pl mentioned this issue Jan 27, 2025
Closed
@lu-pl lu-pl self-assigned this Jan 28, 2025
lu-pl added a commit that referenced this issue Jan 29, 2025
@lu-pl
feat: implement query checking
5ee7f5e 
The change introduces a check_query callable which runs an extensible
compose pipeline of query checkers.

Note regarding QueryParseException: This custom exception is intended
to be a thin wrapper around a pyparsing ParseException that RDFLib
raises. This avoids introducing pyparsing as a dependency just to be able to
test against this exception. I feel like RDFLib should not raise a
pyparsing exception but provide a thin wrapper itself.
See RDFLib/rdflib#3057.

The check_query function runs in SPARQLModelAdapter to enable fast
failures on inapplicable queries. Note that this somewhat couples
QueryConstructor to SPARQLModelAdapter; QueryConstructor should be
marked private for this reason.

Possible handling of queries with outer-level solution modifiers is
discussed in issue #206.

Closes #116. Closes #126.
lu-pl added a commit that referenced this issue Jan 29, 2025
@lu-pl
feat: implement query checking
d25b5af 
The change introduces a check_query callable which runs an extensible
compose pipeline of query checkers.

Note regarding QueryParseException: This custom exception is intended
to be a thin wrapper around a pyparsing ParseException that RDFLib
raises. This avoids introducing pyparsing as a dependency just to be able to
test against this exception. I feel like RDFLib should not raise a
pyparsing exception but provide a thin wrapper itself.
See RDFLib/rdflib#3057.

The check_query function runs in SPARQLModelAdapter to enable fast
failures on inapplicable queries. Note that this somewhat couples
QueryConstructor to SPARQLModelAdapter; QueryConstructor should be
marked private for this reason.

Possible handling of queries with outer-level solution modifiers is
discussed in issue #206.

Closes #116. Closes #126.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lu-pl lu-pl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lu-pl