Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors running external detectors are silently ignored #17

Closed
sbliven opened this issue Jul 27, 2018 · 1 comment
Closed

Errors running external detectors are silently ignored #17

sbliven opened this issue Jul 27, 2018 · 1 comment

Comments

@sbliven
Copy link
Contributor

sbliven commented Jul 27, 2018

Errors running external detectors aren't displayed to the user. This was apparent with the Phobos error (#12). Stderr does get logged to a file in /tmp, but the folder gets deleted immediately. The result code seems to be ignored (see repeat_detection_run.run_detector() line 1010).

TRAL should log an error message for nonzero exit codes. It should also leave the log files accessible upon errors rather than deleting everything.
@sbliven
Copy link
Contributor Author

sbliven commented Nov 22, 2018

This will be fixed in #21

@sbliven sbliven closed this as completed Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbliven