Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unused either dependency #60

Open
ghost opened this issue Nov 23, 2020 · 2 comments
Open

Drop unused either dependency #60

ghost opened this issue Nov 23, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Nov 23, 2020

It seems like the either trans. instances were replaced (#39) a long time ago and at this moment there is no any usage of either package at all
I was able to compile the latest version of this package with cabal either dep. dropped
Please check out if the dependency can be dropped
@acowley
Copy link
Owner

acowley commented Nov 23, 2020

Thank you! If you open a PR with that change, I will gladly merge it.

I'd really like to get us over to GH Actions for CI to better automate testing changes like this, but haven't had the chance to do so.

@gelisam
Copy link
Collaborator

gelisam commented Nov 24, 2020

I'd really like to get us over to GH Actions for CI to better automate testing changes like this

I'm giving it a try in #61

@ghost ghost mentioned this issue Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gelisam @acowley