Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about removing riemann dependency #9

Open
neshtea opened this issue Dec 19, 2023 · 1 comment
Open

Think about removing riemann dependency #9

neshtea opened this issue Dec 19, 2023 · 1 comment

Comments

@neshtea
Copy link
Member

neshtea commented Dec 19, 2023

active-logger contains utilities for connecting and logging to a Riemann instance. While this may come in handy, most projects -- in general -- will not use this. Since most of our Clojure projects (should) depend on active-logger, I find it unnecessary so include Riemann in the bill of materials of every project.

My suggestion would be to pull out the Riemann specific namespace (active.clojure.logger.riemann) and put it in it's own project as a kind of active-logger 'adapter'. This might cause slight overhead, but since I only know of one project that uses the Riemann configuration/appender, it might be worth it,

Thoughts?

@cresh
Copy link
Contributor

cresh commented Dec 19, 2023

Good idea! I'd like to see it go the whole way, though, a full separation of api and backends, see #3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants