Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Test and Benchmark Builds Properly #791

Open
beomki-yeo opened this issue Aug 19, 2024 · 1 comment
Open

Separate Test and Benchmark Builds Properly #791

beomki-yeo opened this issue Aug 19, 2024 · 1 comment
Labels
enhancement New feature or request refactor refactoring the current codes

Comments

@beomki-yeo
Copy link
Collaborator

Two things to suggest:

  1. I cannot build the benchmark code without building the test code because test type is in test directory. I want to move the test type to more common place.

  2. Integration tests with toy detector takes too much time (>700 sec on my laptop). They may need some optimization.
@beomki-yeo beomki-yeo added enhancement New feature or request refactor refactoring the current codes labels Aug 19, 2024
@beomki-yeo beomki-yeo changed the title Improving the tests Separate Test and Benchmark Builds Properly Sep 12, 2024
@niermann999
Copy link
Contributor

The benchmarks can now be built without the tests and actsvg. Does that address point 1?
About point 2: The CI seems to run this in ~60sec. Are you sure you ran this in a release build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request refactor refactoring the current codes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niermann999 @beomki-yeo