Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__init__() arguments are not Pin objects #25

Open
FoamyGuy opened this issue Jan 24, 2022 · 3 comments
Open

__init__() arguments are not Pin objects #25

FoamyGuy opened this issue Jan 24, 2022 · 3 comments

Comments

@FoamyGuy
Copy link
Contributor

We recently changed argument names for initializing the ESP32SPI library to use the suffix _dio rather than _pin because the arguments need to be instantiated DigitalInOut objects, not microcontroller.Pin objects.

See: adafruit/Adafruit_CircuitPython_ESP32SPI#121

This library uses the same *_pin names for it's arguments which are also expected to the DigitalInOuts rather than Pins.

I think we'll want to change the names here and any other libraries that have _pin to keep things consistent across libraries.

@makermelissa
Copy link
Collaborator

You could also check if the arguments are pins and init them as DigitalIOs automatically.

@tekktrik
Copy link
Member

This wouldn't work if said pins were initialized as DigitalIOs elsewhere, right?

@tekktrik
Copy link
Member

I couldn't find where this issue exists in the library, is this issue still accurate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants