Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN check warning found in rgrass reverse dependency checks #117

Closed
rsbivand opened this issue Jan 2, 2025 · 6 comments
Closed

CRAN check warning found in rgrass reverse dependency checks #117

rsbivand opened this issue Jan 2, 2025 · 6 comments

Comments

@rsbivand
Copy link

rsbivand commented Jan 2, 2025

There is a WARNING in revdeps, also with your development version:
00check.log

Please check on 4.4.2 and updated devtools/roxygen2 etc. to replicate.

Note also that rgrass is now at https://github.com/OSGeo/rgrass and a fresh release is forthcoming, but your warning is not related to that, but to stale roxygen markup.

@adamlilith
Copy link
Owner

Thank you for pointing this out, Roger. I am not able to recreate the warning using R CMD check in Windows, the only platform to which I have direct access. Maybe the issue is with how roxygen2 create links... The function is named reac_VECT (for example), but the file is readVECT. Nonetheless, I changed the references to \code{\link[rgrass]{read_VECT}}`, which may obviate the warning.

adamlilith added a commit that referenced this issue Jan 5, 2025
@adamlilith
Copy link
Owner

These are not pulled yet--they're only on the dev branch.

@rsbivand
Copy link
Author

rsbivand commented Jan 5, 2025

Ok, thanks, will try the dev branch on Monday.

@adamlilith
Copy link
Owner

I wonder if it's related to this from Robert H: #118

I fixed that the same way, but I could never create the issue.

@rsbivand
Copy link
Author

rsbivand commented Jan 6, 2025

Looks OK:
00check.log
from branch intuitive_fasterRaster.

@adamlilith
Copy link
Owner

Good--and thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants