You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi Adam, I found your library whilst searching for source code to improve my understanding of regular expressions and console helper libraries.
I am very new to open source, but wondered if you think it would be a useful improvement to add a noConflict() method to the library (e.g. well known example in underscore.js). At least to me, it would seem that 'log' as a global object has the potential to conflict with other global variables given how close semantically it is to programming terminology in general. There are a lot of use cases for the word log!
Your documentation mentions that the syntax follows markdown styling, but that doesn't match what I found here: [(https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet)]
Do you think there would be any benefit in getting these two to match? I would appreciate the opportunity to have a go at adding these features if you agree with my thinking. I would be happy to submit tests for the new code.
Regards,
Rick
The text was updated successfully, but these errors were encountered:
Hey Rick, thanks for this research! Welcome to OS :)
I think support for the user to assign the library to something other than window.log would be a great addition. Please feel free to submit a PR which does that. I’m not sure if I love the nomenclature of noConflict() though. I’m open to suggestion.
As for true Markdown support, please create a separate ticket to discuss that.
Hi Adam, I found your library whilst searching for source code to improve my understanding of regular expressions and console helper libraries.
I am very new to open source, but wondered if you think it would be a useful improvement to add a noConflict() method to the library (e.g. well known example in underscore.js). At least to me, it would seem that 'log' as a global object has the potential to conflict with other global variables given how close semantically it is to programming terminology in general. There are a lot of use cases for the word log!
Your documentation mentions that the syntax follows markdown styling, but that doesn't match what I found here: [(https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet)]
Do you think there would be any benefit in getting these two to match? I would appreciate the opportunity to have a go at adding these features if you agree with my thinking. I would be happy to submit tests for the new code.
Regards,
Rick
The text was updated successfully, but these errors were encountered: