Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a way to include the library into an arbitrary namespace #42

Open
rickhallett opened this issue Mar 4, 2018 · 2 comments
Open

Comments

@rickhallett
Copy link

Hi Adam, I found your library whilst searching for source code to improve my understanding of regular expressions and console helper libraries.

I am very new to open source, but wondered if you think it would be a useful improvement to add a noConflict() method to the library (e.g. well known example in underscore.js). At least to me, it would seem that 'log' as a global object has the potential to conflict with other global variables given how close semantically it is to programming terminology in general. There are a lot of use cases for the word log!

Your documentation mentions that the syntax follows markdown styling, but that doesn't match what I found here: [(https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet)]

Do you think there would be any benefit in getting these two to match? I would appreciate the opportunity to have a go at adding these features if you agree with my thinking. I would be happy to submit tests for the new code.

Regards,
Rick

@adamschwartz
Copy link
Owner

Hey Rick, thanks for this research! Welcome to OS :)

I think support for the user to assign the library to something other than window.log would be a great addition. Please feel free to submit a PR which does that. I’m not sure if I love the nomenclature of noConflict() though. I’m open to suggestion.

As for true Markdown support, please create a separate ticket to discuss that.

@rickhallett
Copy link
Author

Thats great Adam, thanks! I shall give some thought to the implementation regarding the specifics

@adamschwartz adamschwartz changed the title noConflict() Offer a way to include the library into an arbitrary namespace Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants