-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve custom style syntax #43
Comments
Hey again, Rick! I’ve never been particularly satisfied with |
Once I've played with regexp I will see if I can generate some other suggestions! |
@adamschwartz the only other syntax I feel isn't difficult to read is something akin to the handlebars templating syntax, perhaps like Beyond that, I haven't been able to create anything that isn't pretty ugly. I did a small poll on a slack channel I'm a member of and most people preferred the one initially suggested as it mimics HTML style tags. Any thoughts? |
Thanks for conducting that poll! As strange as it may sound, I might be more of a fan of something like Another possible syntax which might be worth considering is something like "custom element" support, with an associated style object. This would allow for style reusability which none of the current options support (without manually using variables and string concatenation). Something like this: log(`
<header>Result</header>
<green>The result was successful.</green>
<header>Instructions</header>
- Re-run the test by refreshing the page.
- Add query parameters <code>?safe=true</code> to run the test in safe mode.
`, {
header: {
'font-family': 'system-ui, sans-serif',
'font-size': '13px',
'color': '#444',
'padding': '8px 0',
'line-height': '40px'
},
green: {
'color': 'green'
},
code: {
'font-family': 'monospaced',
'background': '#eee'
}
}) |
Wow, that is quite an idea - I can see your thinking for sure. In my opinion, it would be a huge improvement to the current implementation. This is a sizeable piece of work for someone of my ability - would you like me to try and implement this? I would be keen to give it a go. |
Up to you! |
Hey, I built a similar project based on your ideas https://github.com/jukben/stylog You might want to check it out. 🚀 |
Do you think that something like
log('this is <style="color: red">red</style>')
makes the API syntax more specific? I think particularly in terms of beginners and consistency with HTML.Best regards,
Rick
The text was updated successfully, but these errors were encountered: