Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 test fails - box_spec.rb:53 #4

Open
utgarda opened this issue Feb 2, 2010 · 1 comment
Open

1 test fails - box_spec.rb:53 #4

utgarda opened this issue Feb 2, 2010 · 1 comment

Comments

@utgarda
Copy link

utgarda commented Feb 2, 2010

Hi! And thanks for your great code :)

Got a failed test while building rush, here's the output :

rake --trace
(in /home/etsvigun/devenv/ruby/rush)
** Invoke default (first_time)
** Invoke spec (first_time)
** Execute spec
.............................................................................................................................................................................................................................................................................F................

'Rush::Box converts environment variables to_s' FAILED
expected: "export a=""\nexport b="123"\ncmd",
got: "export b="123"\nexport a=""\ncmd" (using ==)
./spec/box_spec.rb:53:
/usr/lib64/ruby/1.8/timeout.rb:53:in `timeout'

Here's what I use:

etsvigun@linux-k6ka:/devenv/ruby/rush> ruby --version
ruby 1.8.7 (2008-08-11 patchlevel 72) [x86_64-linux]
etsvigun@linux-k6ka:
/devenv/ruby/rush> rake --version
rake, version 0.8.7
etsvigun@linux-k6ka:~/devenv/ruby/rush> gem list

*** LOCAL GEMS ***

chipmunk-ffi (1.0.0)
ffi (0.6.0, 0.5.4)
gem_plugin (0.2.3)
gemcutter (0.3.0)
git (1.2.5)
jeweler (1.4.0)
json (1.2.0)
json_pure (1.2.0)
nice-ffi (0.3)
rake (0.8.7)
rake-compiler (0.7.0)
rspec (1.3.0)
ruby-processing (1.0.8)
rubyforge (2.0.3)
rubygems-update (1.3.5)
session (2.4.0)

It only works for me if I change box_spec:53 to this, don't know if that's ok :

["export a=""\nexport b="123"\ncmd", "export b="123"\nexport a=""\ncmd"].should include(@box.command_with_environment('cmd', { :a => nil, :b => 123 }))

@AlekSi
Copy link

AlekSi commented Mar 26, 2010

Hash is unordered in Ruby 1.8. Fixed by http://github.com/AlekSi/rush/commit/5cb2bfba31b7a75c433f71b619709986c4082ab7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants