Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_start_sign_ups() Cleanup #26

Open
github-actions bot opened this issue Sep 25, 2021 · 0 comments
Open

test_start_sign_ups() Cleanup #26

github-actions bot opened this issue Sep 25, 2021 · 0 comments

Comments

@github-actions
Copy link

test_start_sign_ups() Cleanup

this test requires major cleanup

async def test_start_sign_ups():

category, channel, reaction, message = ['category', 'channel', 'reaction', 'message']

# TODO test_start_sign_ups() Cleanup

    message_mock.add_reaction.assert_called_with(reactions)
    channel_mock.send.assert_called_with(message)

# TODO test_start_sign_ups() Cleanup
# labels: tests
# this test requires major cleanup

# @pytest.mark.asyncio
# async def test_start_sign_ups():
#     category, channel, reaction, message = ['category', 'channel', 'reaction', 'message']

#     # TODO Future cleanup
#     # labels: cleanup, quick
#     # Look for where we are creating futures and clean up by using future_creator from utils
#     category_future = Future()
#     channel_future = Future()
#     reaction_future = Future()

#     category_future.set_result(category)
#     channel_future.set_result(channel)
#     reaction_future.set_result(reaction)

#     phase_mock._create_category.return_value = category_future
#     phase_mock._create_text_channel_category.return_value = channel_future
#     phase_mock._send_message_to_channel.return_value = reaction_future

#     assert await phase._start_sign_ups(ctx_mock, category, channel, reaction, message) == { 
#         'STATUS': 'start_up_completed',
#         'category': category,
#         'channel': channel,
#         'reaction': reaction
#     }

#     phase_mock._create_category.assert_called_with(ctx_mock, category)
#     phase_mock._create_text_channel_category.assert_called_with(ctx_mock, channel, category)
#     phase_mock._send_message_to_channel.assert_called_with(message, channel, reaction)

8201968f2bca4eab025a9682aa24ed4388786792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants