Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket(int sock_fd) constructor is not RAII. Replace with move consturctor. #5

Open
adityasule opened this issue Jan 5, 2016 · 0 comments
Open

Socket(int sock_fd) constructor is not RAII. Replace with move consturctor. #5

adityasule opened this issue Jan 5, 2016 · 0 comments
Assignees
@Eccmms

Comments

@adityasule
Copy link
Owner

Sockets::Socket::Socket(int sock_fd) constructor is no good. Get rid of it. Replace it with a move constructor that takes ownership of a socket, and frees other object of ownership. Maybe the thing should be set to 0 or some shit so it cannot be used again. I don't know figure something out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eccmms Eccmms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adityasule @Eccmms