Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organize phoenix routes like we do with mix configs #160

Open
novaugust opened this issue Apr 23, 2024 · 2 comments
Open

organize phoenix routes like we do with mix configs #160

novaugust opened this issue Apr 23, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@novaugust
Copy link
Contributor

novaugust commented Apr 23, 2024

  • sort by path, controller, action, dsl_name
  • remove scope which only set a path, and add that path to the children (implicit grouping no longer needed as styler will maintain the grouping)

will probably just ship this as a task that can be run in isolation to start with, letting people use it once and then put things how they want them otherwise

@novaugust novaugust added the enhancement New feature or request label Apr 23, 2024
@novaugust
Copy link
Contributor Author

novaugust commented Apr 23, 2024

an example of why we wouldn't want to do this:

      get("/request_anonymization", UserController, :request_anonymization)
      get("/cancel_anonymization", UserController, :cancel_anonymization)

sure, it would've been better if the author had done get "/anonymization/request" but we don't choose the code we inherit ^.^

@Gladear
Copy link

Gladear commented Aug 10, 2024

Just stumbled across this issue : I personally think this is a good idea, however I think grouping by controller first would be nice - then path, action, dsl_name. Controllers should be a nice heuristic to find related paths, and it solves the problem raised in your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants