testenvSettings.sh should only run once

[llxia]

When USE_TESTENV_PROPERTIES=true and DYNAMIC_COMPILE=false, testenvSettings.sh gets triggered twice - once in compile.sh and once before make <test>. This does not cause any issues, but it is not necessary.

aqa-tests/compile.sh

Line 12 in 83bec27

source ./scripts/testenv/testenvSettings.sh

aqa-tests/buildenv/jenkins/JenkinsfileBase

Line 9 in 83bec27

String makeTestCmd = "$RESOLVED_MAKE;cd ./aqa-tests; . ./scripts/testenv/testenvSettings.sh;cd ./TKG; \$MAKE $testParam"

Console output:

00:01:13.427  + bash ./compile.sh
00:01:13.427  Set values based on ./testenv/testenv.properties:
00:01:13.427  =========
00:01:13.427  TKG_REPO=https://github.com/adoptium/TKG.git
00:01:13.427  TKG_BRANCH=master
...

00:02:11.016  + MAKE=make
00:02:11.016  + cd ./aqa-tests
00:02:11.016  + . ./scripts/testenv/testenvSettings.sh
00:02:11.016  ++ set +x
00:02:11.016  Set values based on ./testenv/testenv.properties:
00:02:11.016  =========
00:02:11.016  TKG_REPO=https://github.com/adoptium/TKG.git
00:02:11.016  TKG_BRANCH=master
...

We should add an if statement in

aqa-tests/buildenv/jenkins/JenkinsfileBase

Line 9 in 83bec27

String makeTestCmd = "$RESOLVED_MAKE;cd ./aqa-tests; . ./scripts/testenv/testenvSettings.sh;cd ./TKG; \$MAKE $testParam"

run . ./scripts/testenv/testenvSettings.sh only if DYNAMIC_COMPILE == true

[Sangyoon21]

I could work on it

[Sangyoon21]

@Hana3706 She would push the pull request on this with me.

[Sangyoon21]

@smlambert Sorry but could you reassign it to @Hana3706. She is working on it

[smlambert]

In order to assign to a contributor, they have to add a comment to the issue. @Hana3706 - please comment on this issue, to have it assigned to you. Thanks!

[Hana3706]

I am so sorry for the confusion. I will work on this issue :)

[smlambert]

No problem Hana3706, it reminded us that we should update our Contributing.md document to mention that one must make a comment if they want to be assigned to an issue. :)

[Hana3706]

I am just a bit confused about what further changes I should make to this issue. So I would be very thankful for a simple tip...
Thanks :)

[llxia]

@Hana3706 Please see the comment: #5341 (comment)

[Hana3706]

I have updated the if statement however my new commit shows under issue #5341 and is pending for review
(I apologize am super confused)

[llxia]

@Hana3706 #5297 is the issue and #5341 is the PR. It is correct for the code to show in #5341.