-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ant version to 1.10.14 #3074
Comments
@smlambert @andrew-m-leonard What are your thoughts on this? Changing the version could obviously introduce behaviour differences (albeit low risk). Have newer versions been tested with the AQA/TC suites and SBOM generation processes? |
Would seem sensible, i've not tested anything new though |
This has resurfaced as a question after I queried that we'd updated it in the Fedora static docker images. @smlambert Would you have any concerns related to moving up to 1.10.12 or the latest one in light of the fact we've already bumped to 1.10.12 in some cases. 1.10.14 is the latest. @andrew-m-leonard We should likely verify that later versions do not break the SBoM generation too before switching over. If a playbook change is made here then the build process will be first to see it. If we do this we should also consider whether to switch existing installations up or leave them as-is. |
Bumping to newer or latest is likely fine, we should verify that test pipelines still function as expected before delivering the change broadly. |
@Haroon-Khel - do you think you can look at trialling this for an AQA_Test_Pipeline on a static docker container with the latest ant release? If that works we can bump it in all the static dockerfiles for new machines (I don't mind too much if older ones are left as-is) then we can also look at making sure the build+SBoM generation work with an updated version before changing it in the playbooks. |
Verified that the SBoM generation in a build of jdk21u on Linux/aarch64 is fine with ant 1.10.14 (released yesterday), so this should be good from a build perspective, so it just needs to be verified for test. |
Ant v1.10.15 has been tested, added to the playbooks and rolled out to our linux, mac, windows and aix machines |
@Haroon-Khel Can you take a look at these AIX runs please? Not sure if ant-contrib is missing, or if it's related to the recent PATH changes or some other upstream change in TKG:
Sample error:
Some of the other test jobs initiated from https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-aix-ppc64-temurin/380/console are also affected |
Not sure how I missed ant-contrib.jar on some of those machines, but it is now on those machines. Ill respin those test jobs |
I would suggest that we put the security checks in place and then discuss that as a separate issue. I'd want there to be additional testing on a new ant version in order to ensure we don't have compatibility issues before just bumping it up (especially sine this PR is specific to Windows and we use the same fixed version across all platforms IIRC) - perhaps create a new issue proposing an upgrade? It's probably about time we did look at that.
ant
is critical to the test case executions and also now for the SBOM generation.Originally posted by @sxa in #3018 (comment)
The text was updated successfully, but these errors were encountered: