Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make does not identify paths with spaces properly. #11

Open
tanvikini opened this issue Nov 21, 2017 · 0 comments · May be fixed by #12
Open

Make does not identify paths with spaces properly. #11

tanvikini opened this issue Nov 21, 2017 · 0 comments · May be fixed by #12

Comments

@tanvikini
Copy link

tanvikini commented Nov 21, 2017 •
edited
Loading

While building openj9, if the path passed to the make command has a space in the middle, the make seems to be identifying the portion after the space as a target, causing the build the fail.

Here is a trace :

C:\Users\IBM_ADMIN\Desktop>"c:\Program Files (x86)\Microsoft Visual Studio 10.0
VC\vcvarsall.bat" amd64 && make -C C:\Users\IBM_ADMIN\git\openj9-systemtest\op
enj9.test.sharedClasses.jvmti/src/native SRCDIR=C:\Users\IBM_ADMIN\git\openj9-sy
stemtest\openj9.test.sharedClasses.jvmti/src/native PLATFORM=win_x86-64 JAVA_HOM
E=C:\Users\IBM_ADMIN\Desktop\Java Builds\sdk OUTDIR=C:\Users\IBM_ADMIN\git\openj9
-systemtest\openj9.test.sharedClasses.jvmti/bin/native
Setting environment for using Microsoft Visual Studio 2010 x64 tools.
make: Entering directory `C:/Users/IBM_ADMIN/git/openj9-systemtest/openj9.test.s
haredClasses.jvmti/src/native'

make: *** No rule to make target `Builds\sdk'. Stop.

make: Leaving directory `C:/Users/IBM_ADMIN/git/openj9-systemtest/openj9.test.sharedClasses.jvmti/src/native'
tanvikini added a commit to tanvikini/openj9-systemtest that referenced this issue Nov 21, 2017
@tanvikini
Changes made to build.xml
2d9439e 
Added double quotes where the variables JAVA_HOME, SRCDIR and OUTDIR are
being set in the build.xml under openj9.test.sharedClasses.jvmti so as to
recognise paths as contiguous even with spaces in directory names.

Fixes : adoptium#11

Signed-off-by: Tanvi Kini <[email protected]>
@tanvikini tanvikini linked a pull request Nov 21, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes made to build.xml tanvikini/openj9-systemtest
1 participant
@tanvikini