Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to VS2017 for Win32 builds once 11.0.4 patches land #1026

Open
karianna opened this issue Apr 9, 2019 · 9 comments
Open

Move to VS2017 for Win32 builds once 11.0.4 patches land #1026

karianna opened this issue Apr 9, 2019 · 9 comments
Assignees
@d3r3kk
Labels
enhancement Issues that enhance the code or documentation of the repo in any way windows Issues that affect or relate to the WINDOWS OS
Milestone
Icebox

Comments

@karianna
Copy link
Contributor

karianna commented Apr 9, 2019 •
edited
Loading

We decided not to fast track the patches into Adopt
@karianna karianna added enhancement Issues that enhance the code or documentation of the repo in any way windows Issues that affect or relate to the WINDOWS OS labels Apr 9, 2019
@karianna karianna added this to the April 2019 milestone Apr 9, 2019
@sxa
Copy link
Member

sxa commented Apr 15, 2019

Only Win32? I don't believe we're there on Win64/HotSpot yet so perhaps we should do it on both bitnesses [*]

[*] - I think I just invented a new word

@karianna
Copy link
Contributor Author

x64 is already using 2017 toolchain

@sxa
Copy link
Member

sxa commented Apr 15, 2019

Ah yes for JDK11 it is indeed ...
As you were :-)

@karianna karianna modified the milestones: April 2019, May 2019 May 1, 2019
@karianna karianna modified the milestones: May 2019, June 2019 Jun 3, 2019
@karianna karianna modified the milestones: June 2019, July 2019 Jul 5, 2019
@karianna karianna modified the milestones: July 2019, August 2019 Aug 6, 2019
@karianna karianna modified the milestones: August 2019, September 2019 Sep 2, 2019
@karianna karianna modified the milestones: September 2019, October 2019 Oct 4, 2019
@karianna karianna modified the milestones: October 2019, November 2019 Nov 3, 2019
@sxa sxa modified the milestones: November 2019, Icebox Dec 3, 2019
@karianna karianna mentioned this issue Mar 6, 2020
Closed
@sxa
Copy link
Member

sxa commented Oct 29, 2020

@karianna Is there anything you're aware of stopping us moving this forward now?

@sxa sxa mentioned this issue Oct 29, 2020
Open
@aahlenst
Copy link
Contributor

aahlenst commented Oct 29, 2020 •
edited
Loading

Has the due dilligence been made? Are we on par with upstream? We're still having problems with Java software not launching on Windows with JDK 8 because we're using a newer toolchain than OpenJDK (adoptium/adoptium-support#30).

https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms

@karianna karianna assigned d3r3kk and unassigned ali-ince Oct 29, 2020
@karianna
Copy link
Contributor Author

@d3r3kk - Moving to you...

@sxa sxa mentioned this issue Nov 18, 2020
Closed
@sxa
Copy link
Member

sxa commented Feb 3, 2021

@karianna @d3r3kk Are we going to progress this? Somebody speak to me please!

@sxa sxa mentioned this issue Feb 3, 2021
Merged
@sxa
Copy link
Member

sxa commented Feb 3, 2021

Despite the name of the PR, #2147 has changed this to VS2017, therefore closing

@sxa sxa closed this as completed Feb 3, 2021
@sxa
Copy link
Member

sxa commented Feb 4, 2021

Reopening in light of #466 (comment)

@sxa sxa reopened this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d3r3kk d3r3kk

Labels
enhancement Issues that enhance the code or documentation of the repo in any way windows Issues that affect or relate to the WINDOWS OS
Projects
None yet
Milestone
Icebox
Development

No branches or pull requests
5 participants
@karianna @aahlenst @sxa @d3r3kk @ali-ince