Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler needs to be VS2017 and not VS2013 #901

Closed
PhilipMorrisJones opened this issue Feb 20, 2019 · 3 comments
Closed

Compiler needs to be VS2017 and not VS2013 #901

PhilipMorrisJones opened this issue Feb 20, 2019 · 3 comments
Assignees
Labels
question Issues that are queries about the code base or potential problems that have been spotted
Milestone

Comments

@PhilipMorrisJones
Copy link

Platform:
Windows

Architecture:

Please describe the issue that you are having with our binaries and if possible how to recreate it.

Hi, I was looking at dependencies and the Oracle build of OpenJDK is built using VS2017 and on AdoptOpenJDK it uses VS2013. Why is this so?

So you get different vs runtimes that are echoed with java -Xinternalversion

C:\Users\cd2fqo\root>dir OracleOpenJDK\jdk-11.0.2\bin\msv*
 Volume in drive C is System
 Volume Serial Number is 5645-DA9D

 Directory of C:\Users\cd2fqo\root\OracleOpenJDK\jdk-11.0.2\bin

17/01/2019  21:35           687,240 msvcp140.dll
               1 File(s)        687,240 bytes
               0 Dir(s)  89,690,595,328 bytes free

C:\Users\cd2fqo\root>dir "AdoptOpenJDK\jdk-11.0.2+9\bin\msv*
 Volume in drive C is System
 Volume Serial Number is 5645-DA9D

 Directory of C:\Users\cd2fqo\root\AdoptOpenJDK\jdk-11.0.2+9\bin

28/01/2019  20:08           650,232 msvcp120.dll
28/01/2019  20:08           953,336 msvcr120.dll
               2 File(s)      1,603,568 bytes
               0 Dir(s)  89,690,595,328 bytes free

Oracle

OpenJDK 64-Bit Server VM (11.0.2+9) for windows-amd64 JRE (11.0.2+9), built on Jan 18 2019 05:23:22 by "mach5one" with MS VC++ 15.5 (VS2017)```

AdoptOpenJDK

``` .\jdk-11.0.2+9\bin\java -Xinternalversion
OpenJDK 64-Bit Server VM (11.0.2+9) for windows-amd64 JRE (11.0.2+9), built on Jan 28 2019 10:43:15 by "" with MS VC++ 12.0 (VS2013)```
@PhilipMorrisJones
Copy link
Author

May be a duplicate of #466

@karianna karianna added the question Issues that are queries about the code base or potential problems that have been spotted label Feb 22, 2019
@karianna karianna added this to the February 2019 milestone Feb 22, 2019
@karianna karianna modified the milestones: February 2019, March 2019 Mar 2, 2019
@karianna karianna modified the milestones: March 2019, April 2019 Apr 1, 2019
@ali-ince
Copy link
Contributor

Talking specifically for JDK 11 hotspot x64 builds, we’re now using visual studio 2017 and you can grab the latest 11.0.3 release.

I’m closing this since we have the other referenced issue #466 for tracking rest of the builds.

@PhilipMorrisJones
Copy link
Author

Thanks, confirmed as good.

>bin\java.exe -Xinternalversion
OpenJDK 64-Bit Server VM (11.0.3+7) for windows-amd64 JRE (11.0.3+7), built on Apr 18 2019 09:08:27 by "" with MS VC++ 15.8 (VS2017)
>dir bin\ms*
 Volume in drive C is System
 Volume Serial Number is 5645-DA9D

 Directory of C:\Users\cd2fqo\Downloads\jdk-11.0.3+7\bin

25/04/2019  18:12           615,896 msvcp140.dll
               1 File(s)        615,896 bytes
               0 Dir(s)  95,554,240,512 bytes free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Issues that are queries about the code base or potential problems that have been spotted
Projects
None yet
Development

No branches or pull requests

3 participants