Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Talk published_at to date or similar #134

Open
marcoroth opened this issue Aug 16, 2024 · 1 comment
Open

Rename Talk published_at to date or similar #134

marcoroth opened this issue Aug 16, 2024 · 1 comment

Comments

@marcoroth
Copy link
Contributor

marcoroth commented Aug 16, 2024 •
edited
Loading

I understood published_at as "the date the video was published on", but something like date would probably be more accurate.

Originally posted by @marcoroth in #113 (comment)
@marcoroth marcoroth changed the title Updated, maybe we should rename that field then. I understood published_at as "the date the video was published on", but something like date would probably be more accurate. Rename Talk published_at to date or similar Aug 16, 2024
@marcoroth marcoroth mentioned this issue Aug 16, 2024
Merged
@adrienpoly
Copy link
Owner

I agree we should use date so that it is less confusing

in #118 I started to look first for date and then as a fallback published_at

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcoroth @adrienpoly