Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetImagesController#factory_keys should guard against params[:target_image] being nil #93

Open
n1zyy opened this issue Dec 20, 2012 · 0 comments
Assignees

Comments

@n1zyy
Copy link

n1zyy commented Dec 20, 2012

This is probably an edge case (it was only exposed by a separate bug (not in Tim) causing data to be posted to the wrong URL), but the factory_keys method in TargetImagesController begins by checking params[:target_image][:percent_complete].

params[:target_image] can be nil, at least in the case of bad data being passed in, causing the method to raise an undefined method[]' for nil:NilClass` exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants