Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Change fitted estimators and ensemble collections from protected to public #2374

Open
MatthewMiddlehurst opened this issue Nov 20, 2024 · 6 comments
Assignees
Labels
enhancement New feature, improvement request or other non-bug code enhancement

Comments

@MatthewMiddlehurst
Copy link
Member

MatthewMiddlehurst commented Nov 20, 2024

Describe the feature or idea you want to propose

Currently in a lot of estimators we fit an sklearn estimator i.e. _estimator or form an ensemble of estimators i.e. _ensemble or _classifiers but these are protected (starting with an _).

Theres not much reason for them to be protected IMO.

Describe your proposed solution

Change fitted estimator attributes from protected to public using our fitted attribute convention i.e. from _estimator to estimator_.

These should then be properly documented in the estimator docstring under "Attributes"

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@MatthewMiddlehurst MatthewMiddlehurst added enhancement New feature, improvement request or other non-bug code enhancement good first issue Good for newcomers labels Nov 20, 2024
@TonyBagnall
Copy link
Contributor

see #2350 for an example

@vedpawar2254
Copy link
Contributor

vedpawar2254 commented Nov 22, 2024

@@aeon-actions-bot assign @vedpawar2254

@aryan0931
Copy link

@aeon-actions-bot assign @aryan0931

@aeon-actions-bot aeon-actions-bot bot removed the good first issue Good for newcomers label Nov 27, 2024
@MatthewMiddlehurst
Copy link
Member Author

@vedpawar2254 the comment has to be made in a new post, just saw this now. See the contributor guide on the webpage.

@MatthewMiddlehurst
Copy link
Member Author

@aryan0931 do you still intend to create a PR for this?

@aryan0931
Copy link

yes I am working on that.

@aryan0931 aryan0931 mentioned this issue Dec 14, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants