-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Anomaly detection module: Add informational tags back to estimator docs #2490
Comments
I'd love to work on this too. Please let me know how can I move forward with it. |
We have not decided on a good way to do this yet. I see the following options:
We need to agree on a good way to represent the information in the current tags-infrastructure. How do other modules handle this? I already described my proposal in #2468 (comment):
@baraline, @MatthewMiddlehurst what do you think? Does this conflict with other modules? Should we add namespaces (e.g., |
As mentioned in the PR, I think tags is a fine solution to this. The discussion on my end is more surrounding how we should name the tags, but I do not think that is essential for these to be implemented. The content of the tags above seem fine to me, though it may be worth discussion if it's worth turning "Learning type" into three distinct tags also. |
@SebastianSchmidl if this is accepted, then should I continue adding this information back? |
I will take this into our next dev meeting to discuss with other module owners on a naming-scheme. Once, we have agreed to one, I'll come back to you. |
Sure, thanks for the response! |
Context
The anomaly detection estimators documented their input data format, output data format, and learning type in a manually maintained capabilities table in the estimator docs.
In #2468, we discussed the need of removing the manually added capabilities table in the Anomaly Detection module in favor of the automatically generated capabilities table from the estimators' tags (#2468 (comment)). The information about the output data format and learning type is now missing. We should add it back.
Please checkout #1430 & #2468 for more information.
Prerequisites
#1430 & #2468
Details
The following information is now missing in the docs:
CBLOF
COPOD
DWT_MLEAD
IsolationForest
KMeansAD
LOF
LeftSTAMPi
MERLIN
OneClassSVM
PyODAdapter
STOMP
STRAY
The text was updated successfully, but these errors were encountered: