Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Coverage for the networks module #2497

Open
TonyBagnall opened this issue Jan 14, 2025 · 5 comments
Open

[ENH] Coverage for the networks module #2497

TonyBagnall opened this issue Jan 14, 2025 · 5 comments
Labels
coverage Code requiring greater test coverage enhancement New feature, improvement request or other non-bug code enhancement networks Networks package testing Testing related issue or pull request

Comments

@TonyBagnall
Copy link
Contributor

Describe the feature or idea you want to propose

networks has a lot of parameters that are not covered in testing, it would be good if they were esp the ae ones @aadya940

Describe your proposed solution

add tests for network parameters

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@TonyBagnall TonyBagnall added enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request networks Networks package coverage Code requiring greater test coverage labels Jan 14, 2025
@Nikitas100
Copy link

Nikitas100 commented Jan 15, 2025

Hello, I would like to contribute by adding tests for the network parameters. I found three test files related to ae in the networks module. Are these the parameters that require additional coverage, or are there other specific areas I should focus on? Any further details or guidance would be appreciated.

@MatthewMiddlehurst
Copy link
Member

While this does not cover every single case and item we want tested, an east place to start is our test coverage https://app.codecov.io/gh/aeon-toolkit/aeon

@Nikitas100
Copy link

Hi @MatthewMiddlehurst ,

I noticed that the tests don't fully cover 10-11 files in the networks module. Would you prefer I start with specific files or parameters, or should I gradually work on covering all uncovered areas?

Thanks!

@aadya940
Copy link
Contributor

@Nikitas100 you can start with any file, typically divide the tasks to 1 network per pull request. :)

@lucifer4073
Copy link

Hi @Nikitas100,

There seems to be a decent number of files which need a higher test coverage. It might be a good idea to collaborate on addressing this issue together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coverage Code requiring greater test coverage enhancement New feature, improvement request or other non-bug code enhancement networks Networks package testing Testing related issue or pull request
Projects
None yet
Development

No branches or pull requests

5 participants