Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge spring-data-aerospike and spring-data-aerospike-starters into this repo #356

Open
Aloren opened this issue Mar 30, 2022 · 1 comment

Comments

@Aloren
Copy link

Aloren commented Mar 30, 2022

There are some issues in the compatibility of these libs:
aerospike-community/spring-data-aerospike-starters@aef3187
aerospike-community/spring-data-aerospike-starters#108 (there was a workaround in the previous version for this, but probably it just got more serious after some major changes to spring or this change 1e5df87 ).

I think that merging this repos should not be a problem, since currently there is only one team supporting the project. Instead it will be possible to see which changes require changes in starter modules and vice versa.

@roimenashe what do you think?

@roimenashe
Copy link
Collaborator

roimenashe commented Mar 31, 2022

@Aloren
I see the advantage of merging these two projects since the starters depends on the spring-data-aerospike and should be aware of any breaking change.
The thing that worries me is the simplicity for users, I’m not sure we want to have a single repository for the entire spring-data-aerospike logic and for the auto configuration/starters since not every user of Spring Data Aerospike uses the Spring Data Aerospike Starters and it can be a bit of a headache for users to understand to purpose of the repository.
Also in spring-projects implementation and starters are separated projects (https://github.com/spring-projects/spring-data-jpa, https://github.com/spring-projects/spring-boot/tree/main/spring-boot-project/spring-boot-starters).

However, I think that in every big change in Spring Data Aerospike we should also check/release a matching version of Spring Data Aerospike Starters (if required).
The reason that it wasn’t the case up till now is because the Spring Data Aerospike Starters was a project maintained and used by Playtika only and kept the specific dependencies that you used (client 4.4.x, spring-data 2.4.x, etc…), I think we should release new versions of starter (if required) aligned with new versions of spring-data and you can use the one you need - if a major release was issued and you only need a minor bug fix and can’t upgrade to the new major release then we can think of tags/branches until its possible for you to upgrade (if we will ever get there since the starters isn’t expected to change that much).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants