Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak Index Grouping Issue #28

Open
ibiglari opened this issue Nov 14, 2023 · 1 comment
Open

Peak Index Grouping Issue #28

ibiglari opened this issue Nov 14, 2023 · 1 comment

Comments

@ibiglari
Copy link

ibiglari commented Nov 14, 2023

https://github.com/afeinstein20/stella/blob/f9ffd78d1c7279012e870f3657812595f18eee74/stella/mark_flares.py#L92C1-L92C33

If groups are not of the same size, this line will cause an exception.

Let's say peaks are detected at tpeak=[100, 150, 151, 152, 191, 192].

This function will try to group them into [[100], [150, 151, 152], [191,192]] and then return this as a two dimensional array, instead of array of arrays, leading to a crash.

Copy link

Hi there! This is a test of github actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant