Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int overflow during serialization of a FULL type HLL when log2m and regwidth are both large #17

Open
hossman opened this issue Aug 27, 2015 · 1 comment

Comments

@hossman
Copy link

hossman commented Aug 27, 2015

BigEndianAscendingWordSerializer and BigEndianAscendingWordDeserializer both suffer from int overflow bugs: multiplying large ints and then assigning to long instead of casting those ints to longs before multiplying them.

I don't have a pull request handy (since this project no longer seems actively maintained, we've forked & imported directly into the Apache Solr code base) but I wanted to file this issue to make existing users aware of the bug -- you can see the details involved in fixing/testing in this issue/commit in the Lucene/Solr code base...

https://svn.apache.org/viewvc?view=revision&revision=1697969
https://issues.apache.org/jira/browse/SOLR-7954

@ragstorooks
Copy link

I've run into the same issue described here and have submitted a new PR. It would be great if you can get it merged so that others facing the same issue can just pull down a newer version rather than fork and maintain their own versions.

Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants