Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampler order for NovelAI problems #826

Open
cingorn opened this issue Feb 7, 2024 · 2 comments
Open

Sampler order for NovelAI problems #826

cingorn opened this issue Feb 7, 2024 · 2 comments

Comments

@cingorn
Copy link
Contributor

cingorn commented Feb 7, 2024

Describe the bug
When you're logged in and edit a NovelAI preset and change sampler order:

  • changes are not saved, when the preset is reopened (it reverts to the default order),
  • trying to use the preset in a chat results in an error from NovelAI API: ("RepeatedLogitId: '%s' was repeated in 'order'", 'temperature')

To Reproduce
Steps to reproduce the behavior:

  1. Log in.
  2. Create a new NovelAI preset.
  3. Change the sampler order and save.
  4. Reopen the preset, changes are not saved.
  5. Create a new chat using the created preset.
  6. Send a message, you either receive a NovelAI API error (when streaming is off) or the chat hangs waiting for the response (streaming on).

Expected behavior

  • Preset changes are saved and cause no errors.

Additional context

  • This happens only when you're logged in.
  • When changing the sampler order, the saved order in the DB is an array of zeros: [0, 0, ...]
  • When these zeros are sent to NovelAI API, it treats it as if temperature (id = 0) was repeated multiple times.
@sceuick
Copy link
Member

sceuick commented Mar 10, 2024

Hopefully resolved now.

@sceuick sceuick closed this as completed Mar 10, 2024
@Kalpira
Copy link

Kalpira commented Mar 10, 2024 via email

@sceuick sceuick reopened this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants