Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beam css leak fix #134

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Beam css leak fix #134

merged 3 commits into from
Jun 11, 2024

Conversation

crabinak
Copy link
Collaborator

@crabinak crabinak commented Jun 8, 2024

I fixed the style leak that was occurring. The HTML element was being styled in beam.css. I have removed it and updated all rem values based on 1em = 16px instead of 1em = 10px they were using before. Let me know if you see any other issues occurring here.

@crabinak crabinak requested a review from agritheory June 8, 2024 20:49
@crabinak crabinak self-assigned this Jun 8, 2024
@Alchez
Copy link
Collaborator

Alchez commented Jun 11, 2024

@crabinak can you please run rush change locally for this branch? It'll prompt you for a changelog message, which should help resolve the tests here

@Alchez Alchez merged commit 47bf9fa into development Jun 11, 2024
6 checks passed
@Alchez Alchez deleted the beam-css-leak-fix branch June 11, 2024 11:32
agritheory pushed a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants