-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aform, atable] added file attach component #138
Conversation
* feat: parse graphQL responses and convert numbers to Decimals * fix: add changelog --------- Co-authored-by: Rohan Bansal <[email protected]>
* fix: avoid recursive rendering issues * ci: add changelog for recursion render fix * fix: pnpm lockfile --------- Co-authored-by: Rohan Bansal <[email protected]>
Coverage Report for ./aform
File Coverage
|
@bhattdevarsh @crabinak I've rebased the previous changes against the latest
|
@Alchez Thanks. I noticed trying to run this now (rushx story:dev) doesn't use Histoire anymore. Has this been updated? |
@crabinak Sorry, I should've mentioned that in the previous comment. All the stories have been consolidated into the
|
@Alchez Thanks! I'm receiving this error when I try to run throw new Error( Am I missing something? I ran |
@crabinak are you running this from the examples folder? We had to move all the specimens there to prevent a circular dependency problem with ATable and AForm. |
@agritheory I'm running this from the examples folder. I'm not sure what is causing this error. This is the case in the development branch as well. I don't know if anyone else ran into this error and had a quick fix for it. This is the full error if it gives any clues.
|
Usually that error shows up when the app can't find a valid Vite file with the Histoire-Vue plugin, which makes me think it might be a dependency issue (atleast because it works for me across multiple devices after purging old builds). Can I ask you to remove any |
@Alchez Thanks for the suggestions. Unfortunately, I had no luck with that. I found that running |
@agritheory Here are some screenshots of the styled file attach component. I also switched the form layout to use CSS grid instead of flexbox for a bit more control over form field sizes and positions. |
@agritheory I reverted the form fields back to flex box as per our discussion. |
Continuing from #122