Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some entities gets dropped from the result #24

Open
chirag4semandex opened this issue Oct 8, 2024 · 0 comments
Open

Some entities gets dropped from the result #24

chirag4semandex opened this issue Oct 8, 2024 · 0 comments

Comments

@chirag4semandex
Copy link

What is the reason for this check?

https://github.com/ahalterman/mordecai3/blob/main/mordecai3/geoparse.py#L449

Because of this, some places get dropped.

Here is an example from the test_moredecai3 tests

Shouldn't this return 2 geo-locations instead of just one ( Oxford )

"Ole Miss is located in Oxford."

- Ole Miss - University of Mississippi as per Geonames ( missed )
- Oxford

Similarly below should also return 2 geo-locations, right?

"Oxford is home to Oxford University, one of the best universities in the world."

- `Oxford` 
- `Oxford University`  ( missed )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant