highcharts v12 fix #493
Open
highcharts v12 fix #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalBryxi
commented
Jan 29, 2025
| @@ -124,6 +124,6 @@ | |||
| }, | |||
| "peerDependencies": { | |||
| "ember-source": ">= 3.28.0", | |||
| "highcharts": ">= 5.0.0" | |||
| "highcharts": ">= 12.0.0" | |||
There was a problem hiding this comment.
This would be 100% a breaking change. Not sure what would mean it wrt/ release strategy of this addon?
MichalBryxi
commented
Jan 29, 2025
| } | ||
|
|
||
| if ( | ||
| this.args.chartOptions?.chart?.type === 'treegraph' || | ||
| this.args.chartOptions?.chart?.type === 'treemap' | ||
| ) { | ||
| const Treemap = await import('highcharts/modules/treemap'); | ||
| Treemap.default(Highcharts); | ||
| await waitForPromise(import('highcharts/modules/treemap')); |
There was a problem hiding this comment.
I can't tell if the waitForPromise is necessary for the few cases where it's missing, but I think it's a good idea to have it unified.
- Those two need some special treatment for some reason
|
Note: The re-render once checkbox is checked, because the test suite is happy. So I guess it will be an issue in my consuming app. |
- Sorry, no idea what it wants.
Issue: ``` You cannot set `staticHelpers`, `staticComponents`, or `staticModifiers` if you have set `staticInvokables`. Delete these configs to continue. ``` Related PR: https://github.com/miguelcobain/ember-yeti-table/pull/473/files Discussion: https://discord.com/channels/480462759797063690/491905849405472769/1328757079510487071
MichalBryxi
commented
Jan 29, 2025
| @@ -203,80 +203,59 @@ export default class HighCharts< | |||
| */ | |||
| async _importHighchartsDeps() { | |||
| if (this.args.mode === 'Map') { | |||
| Highcharts = await waitForPromise(import('highcharts/highmaps')); | |||
| //@ts-expect-error No idea, sielnt TS | |||
There was a problem hiding this comment.
I'm sorry, but no idea what it wants and don't see a cheap way to find out. Not ideal, but solves the problem.
- Not sure why would we want to assign the HighChart to module scope - This way it's tracked, so i guess(?) it might help with the initial render issue - Also so many things were named `Hightcharts`, so this helps
- Somehow there is a difference on my localhost for a consuming app using vite, because that one need the `default` unpack. - Tests pass, because they use webpack, IMO.
|
cc: @ahmadsoe can we 👀 this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@embroider/app-blueprintapp