Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the ocaml-tsort library to sort dependencies #340

Open
mjambon opened this issue May 9, 2023 · 0 comments
Open

Use the ocaml-tsort library to sort dependencies #340

mjambon opened this issue May 9, 2023 · 0 comments
Labels

Comments

@mjambon
Copy link
Collaborator

mjambon commented May 9, 2023

The current implementation used to sort the groups of mutually-recursive type definitions is weird and I suspect is incorrect, leading to bugs such as #308. The ocaml-tsort library (opam: tsort) has a clean implementation based on well-known algorithms, so we should use it. It comes with a dependency on the containers library which I don't think should be a problem.

@mjambon mjambon added the bug label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant