From cb0d238c82d9b3947186434f52e8db993abe999a Mon Sep 17 00:00:00 2001 From: Simon Dold Date: Mon, 16 Sep 2024 11:22:12 +0200 Subject: [PATCH 1/6] update pdb synopsis. --- src/search/pdbs/pdb_heuristic.cc | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/search/pdbs/pdb_heuristic.cc b/src/search/pdbs/pdb_heuristic.cc index 484e4d2eba..b8d622a741 100644 --- a/src/search/pdbs/pdb_heuristic.cc +++ b/src/search/pdbs/pdb_heuristic.cc @@ -33,13 +33,27 @@ int PDBHeuristic::compute_heuristic(const State &ancestor_state) { return h; } +static basic_string paper_references() { + return utils::format_conference_reference( + {"Stefan Edelkamp"}, + "Planning with Pattern Databases", + "https://ecp01.icaps-conference.org/papers/A-longpapers/2/edelkamp.pdf", + "Proceedings of the Sixth European Conference on Planning (ECP 2001)", + "84--90", + "AAAI Press", + "2001"); +} class PDBHeuristicFeature : public plugins::TypedFeature { public: PDBHeuristicFeature() : TypedFeature("pdb") { document_subcategory("heuristics_pdb"); document_title("Pattern database heuristic"); - document_synopsis("TODO"); + document_synopsis( + "Computes dictionaries for state-to-goal distances in" + "state space abstractions based on projections." + "First used in domain idependent planning by:" + + paper_references()); add_option>( "pattern", From dc9305dfd156ef78ec2009d1b02411d525009e49 Mon Sep 17 00:00:00 2001 From: Simon Dold Date: Mon, 16 Sep 2024 11:37:23 +0200 Subject: [PATCH 2/6] fix synopsis. --- src/search/pdbs/pdb_heuristic.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/search/pdbs/pdb_heuristic.cc b/src/search/pdbs/pdb_heuristic.cc index b8d622a741..dfce4e97a9 100644 --- a/src/search/pdbs/pdb_heuristic.cc +++ b/src/search/pdbs/pdb_heuristic.cc @@ -3,6 +3,7 @@ #include "pattern_database.h" #include "../plugins/plugin.h" +#include "../utils/markup.h" #include #include From 31b6f49f2e547657a4b847e4b271ec79e98de43f Mon Sep 17 00:00:00 2001 From: Simon Dold Date: Mon, 16 Sep 2024 12:14:12 +0200 Subject: [PATCH 3/6] add spaces. --- src/search/pdbs/pdb_heuristic.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/search/pdbs/pdb_heuristic.cc b/src/search/pdbs/pdb_heuristic.cc index dfce4e97a9..97678469d8 100644 --- a/src/search/pdbs/pdb_heuristic.cc +++ b/src/search/pdbs/pdb_heuristic.cc @@ -51,8 +51,8 @@ class PDBHeuristicFeature document_subcategory("heuristics_pdb"); document_title("Pattern database heuristic"); document_synopsis( - "Computes dictionaries for state-to-goal distances in" - "state space abstractions based on projections." + "Computes dictionaries for state-to-goal distances in " + "state space abstractions based on projections. " "First used in domain idependent planning by:" + paper_references()); From 7631119c337972de80718fcc76b496a96ddd57a1 Mon Sep 17 00:00:00 2001 From: Simon Dold Date: Mon, 16 Sep 2024 12:21:38 +0200 Subject: [PATCH 4/6] typo. --- src/search/pdbs/pdb_heuristic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/search/pdbs/pdb_heuristic.cc b/src/search/pdbs/pdb_heuristic.cc index 97678469d8..f115a3c2d9 100644 --- a/src/search/pdbs/pdb_heuristic.cc +++ b/src/search/pdbs/pdb_heuristic.cc @@ -53,7 +53,7 @@ class PDBHeuristicFeature document_synopsis( "Computes dictionaries for state-to-goal distances in " "state space abstractions based on projections. " - "First used in domain idependent planning by:" + "First used in domain independent planning by:" + paper_references()); add_option>( From 38cad0e2330fa6ad2694db790b7b39b63a2d4278 Mon Sep 17 00:00:00 2001 From: Simon Dold Date: Mon, 16 Sep 2024 19:11:59 +0200 Subject: [PATCH 5/6] Update link, add ref. to implementation notes, reduce detail. --- src/search/pdbs/pdb_heuristic.cc | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/search/pdbs/pdb_heuristic.cc b/src/search/pdbs/pdb_heuristic.cc index f115a3c2d9..74ab54399d 100644 --- a/src/search/pdbs/pdb_heuristic.cc +++ b/src/search/pdbs/pdb_heuristic.cc @@ -38,11 +38,21 @@ static basic_string paper_references() { return utils::format_conference_reference( {"Stefan Edelkamp"}, "Planning with Pattern Databases", - "https://ecp01.icaps-conference.org/papers/A-longpapers/2/edelkamp.pdf", + "https://aaai.org/papers/7280-ecp-01-2001/", "Proceedings of the Sixth European Conference on Planning (ECP 2001)", "84--90", "AAAI Press", - "2001"); + "2001") + + "For implementation notes, see:" + utils::format_conference_reference( + {"Silvan Sievers", "Manuela Ortlieb", "Malte Helmert"}, + "Efficient Implementation of Pattern Database Heuristics for" + " Classical Planning", + "https://ai.dmi.unibas.ch/papers/sievers-et-al-socs2012.pdf", + "Proceedings of the Fifth Annual Symposium on Combinatorial" + " Search (SoCS 2012)", + "105-111", + "AAAI Press", + "2012"); } class PDBHeuristicFeature : public plugins::TypedFeature { @@ -51,9 +61,9 @@ class PDBHeuristicFeature document_subcategory("heuristics_pdb"); document_title("Pattern database heuristic"); document_synopsis( - "Computes dictionaries for state-to-goal distances in " + "Computes goal distance in " "state space abstractions based on projections. " - "First used in domain independent planning by:" + "First used in domain-independent planning by:" + paper_references()); add_option>( From ad45073a0df593c88102ff1494e6819ebc8a80a3 Mon Sep 17 00:00:00 2001 From: Simon Dold Date: Mon, 16 Sep 2024 19:15:57 +0200 Subject: [PATCH 6/6] use single dash. --- src/search/pdbs/pdb_heuristic.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/search/pdbs/pdb_heuristic.cc b/src/search/pdbs/pdb_heuristic.cc index 74ab54399d..4e6efae28c 100644 --- a/src/search/pdbs/pdb_heuristic.cc +++ b/src/search/pdbs/pdb_heuristic.cc @@ -40,7 +40,7 @@ static basic_string paper_references() { "Planning with Pattern Databases", "https://aaai.org/papers/7280-ecp-01-2001/", "Proceedings of the Sixth European Conference on Planning (ECP 2001)", - "84--90", + "84-90", "AAAI Press", "2001") + "For implementation notes, see:" + utils::format_conference_reference(