Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application cannot be managed by Kebechet due to it containing an unsupported package location. #48

Open
Tracked by #401
khebhut bot opened this issue Oct 14, 2021 · 9 comments
Assignees
Labels
human_intervention_required to a human team mate! kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@khebhut
Copy link

khebhut bot commented Oct 14, 2021

Kebechet cannot support maintaining this application as it contain's local
version of packages.

The package causing the issue is - src
Linked SHA - 17ae6d9

For more information, see Pipfile and Pipfile.lock.

Environment details

Kebechet version: 1.5.5
Python version: 3.8.6
Platform: Linux-4.18.0-305.19.1.el8_4.x86_64-x86_64-with-glibc2.2.5
pipenv version: pipenv, version 2020.11.15


/kind bug
/priority critical-urgent

@sesheta sesheta added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Oct 14, 2021
@sefkhet-abwy sefkhet-abwy bot added human_intervention_required to a human team mate! labels Oct 14, 2021
@MichaelClifford
Copy link
Member

@pacospace @harshad16 The Pipfile.lock as not changed in the past 7 months, but this issue was created today. Do we need to address this issue now? or was it created in error? Since this is the template repo, I'm assuming this issue is relevant to all ai-coe org projects?

@tumido
Copy link
Member

tumido commented Oct 21, 2021

Bump @harshad16 ^

@pacospace
Copy link
Member

Cc @KPostOffice

@KPostOffice
Copy link

@pacospace @harshad16 The Pipfile.lock as not changed in the past 7 months, but this issue was created today. Do we need to address this issue now? or was it created in error? Since this is the template repo, I'm assuming this issue is relevant to all ai-coe org projects?

@MichaelClifford This is something that I updated the other day. Kebechet update manager fails when trying to manage dependencies which are local, so I explicitly created this issue to warn users.

@MichaelClifford
Copy link
Member

Is the src package in the pipfile the culprit?

src = {editable = true, path = "./"}

@KPostOffice
Copy link

Is the src package in the pipfile the culprit?

src = {editable = true, path = "./"}

Yeah, exactly

@JamesKunstle
Copy link

@MichaelClifford @KPostOffice I'm fixing this issue on our end- would it be possible to have a brief explanation of why 'src' is in the Pipfile and whether simply removing that line will fix the problem?

@MichaelClifford
Copy link
Member

MichaelClifford commented Jan 6, 2022

@JamesKunstle yes, I believe removing that line from the Pipfile should fix the problem. As to why it is in there? it looks to be a hold over from one of the fist PR's converting a requirements.txt to a Pipfile #1 .

Also, #50 indicates that its used for notebook based development.

I'll add a PR to remove this from the template going forward. Thanks!

@JamesKunstle
Copy link

@MichaelClifford
Thanks so much for the explanation and for the PR!
This fixes our issue with Kebechet in one shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
human_intervention_required to a human team mate! kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

No branches or pull requests

7 participants