Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Scan seems not to be working on CLI nor script tag #167

Open
Andy9822 opened this issue Dec 25, 2024 · 7 comments
Open

React Scan seems not to be working on CLI nor script tag #167

Andy9822 opened this issue Dec 25, 2024 · 7 comments
Assignees

Comments

@Andy9822
Copy link

Andy9822 commented Dec 25, 2024

Hey guys, I've used React-Scan previously by adding the <script> tag in the index.html file of my React project and it worked just fine 🎉

However, I tried today with an external website and had no luck using it; it didn't work either on the npx <URL> version or injecting the <script> before the page loaded with a Chrome extension 😞 (I tried both x.com and kit.com )

Was there any breaking change recently or am I missing something?

Screen.Recording.2024-12-25.at.12.33.16.1.mp4
@pivanov
Copy link
Collaborator

pivanov commented Dec 25, 2024

Hey @Andy9822
Which extension did you try? this one?

@pivanov pivanov self-assigned this Dec 25, 2024
@Bosseskompis
Copy link

Bosseskompis commented Dec 25, 2024

I have the same problem. Starting from 0.0.51 it simply doesn't detect renders (or has no visual cues for it). 0.0.50 works fine, though it doesn't count the number of renders.

0.0.47 is the last version that works well for me.

@Andy9822
Copy link
Author

Hey @Andy9822 Which extension did you try? this one?

I used this one: https://chromewebstore.google.com/detail/scripty-javascript-inject/milkbiaeapddfnpenedfgbfdacpbcbam?pli=1

And yes, I double checked the "before page loads" option" was set

@pivanov
Copy link
Collaborator

pivanov commented Dec 25, 2024

Hey @Andy9822 Which extension did you try? this one?

I used this one: https://chromewebstore.google.com/detail/scripty-javascript-inject/milkbiaeapddfnpenedfgbfdacpbcbam?pli=1

And yes, I double checked the "before page loads" option" was set

No no ... I mean ... did you try to install the react-scan browser extension?
Check here: CHROME_EXTENSION_GUIDE.md

@Andy9822
Copy link
Author

Hey @Andy9822 Which extension did you try? this one?

I used this one: https://chromewebstore.google.com/detail/scripty-javascript-inject/milkbiaeapddfnpenedfgbfdacpbcbam?pli=1
And yes, I double checked the "before page loads" option" was set

No no ... I mean ... did you try to install the react-scan browser extension? Check here: CHROME_EXTENSION_GUIDE.md

Oh sorry.

Yes, I ran npx react-scan@latest <URL> and then it prompted me to install the latest version which was 0.0.54 (smth like that )

@Andy9822
Copy link
Author

I have the same problem. Starting from 0.0.51 it simply doesn't detect renders (or has no visual cues for it). 0.0.50 works fine, though it doesn't count the number of renders.

0.0.47 is the last version that works well for me.

I can confirm that v0.0.47 did the trick and works just fine.
Thanks for the tip man! gonna be using it in this version for now 😄

@RobPruzan
Copy link
Collaborator

We made a change to our cdn script to not automatically run in production unless forced turned on- which seems to have broken the cli

Fix in the works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants